James Madison was a great theorist, extraordinary writer, cunning politician and an effective legislator – but as president he was simply “good”.